Re: [gtk-vnc-devel] [PATCH] gtkgl based scaling

[Anthony Liguori <anthony codemonkey ws>]

Daniel P. Berrange wrote:
> > How is performance?  I don't have access to the machine that has the 
> > problem ATM so I can't test myself.  I added a swap_buffers() call 
> > myself but it ended up killing performance.
> >     
>
> Well I've not tried the swap_buffers() code path myself. The glFlush()
> path has a noticable performance impact on my laptop, but that's not a
> fair test since this is a ATI r500 card with the open source driver so
> it doesn't even have 2-d acceleration, let alone 3-d.  I'll test on an
> accelerated Intel / NVidia card when I get a chance.
>   

It doesn't appear to affect performance much on my laptop so I committed 
this patch.  Since we specifically don't do double buffering, I removed 
that code.  Based on my experiences with swapping the buffers, I think 
if we need to swap the buffer, we need to use a delayed timer instead of 
doing it on every expose.  I'd rather have people report bugs with 
screen corruption than having terrible performance since they may not 
report the later.

Thanks!

Regards,

Anthony Liguori

> Dan.
>