Re: My build_filename() patch

[Armin Burgmeier <armin arbur net>]

On Mon, 2009-10-26 at 09:48 -0200, Fabrício Godoy wrote:
> Hi,
> 
> 2009/10/26 Mark Roberts <gtkmm manumark de>
>         Dear Fabrício and list,
>         
>         
>         
>         Fabrício wrote:
>         
>                 I submited a patch in #599578[1].
>                 Thanks.
>                 
>                 References:
>                 1- https://bugzilla.gnome.org/show_bug.cgi?id=599578
>         
>         
>         Your code includes this sort of code a few times:
>         
>          path = g_build_filename(ustr1.c_str(), ustr2.c_str(),
>         NULLPOINTER);
>          Glib::ustring r_path(path);
>          g_free(path);
>          return r_path;
>         
>         Surely if out-of-memory, g_build_filename() will return 0 and
>         ustring::ustring() will throw a bad-argument exception, which
>         the customer will not understand. We want to throw the
>         no-memory-exception, don't we?
>         
>         All the best,
>         Mark
> 
> You're so right.
> 
> Unfortunately g_build_filename documentation[1] don't warns about any
> error.

Maybe this is because there aren't any. I guess g_build_filename uses
g_malloc, and g_malloc abort()s the program instead of returning a
nullpointer if it runs out of memory.

Armin