Re: [gupnp] [PATCH] Fix syntax of property sets with multiple properties.

["Zeeshan Ali (Khattak)" <zeenix gmail com>]

On Mon, May 17, 2010 at 6:22 PM, Sven Neumann <s neumann raumfeld com> wrote:
> Hi guys,
>
> with this patch applied on all services, things work nicely again.

  Great! Thanks for the patch.

> However it might be a good idea to also revert the removal of the
> redundant loop. That way the gupnp stack would stay compatible with
> devices running version 0.12. IMO it is pretty bad if such devices all
> of a sudden don't work any longer if the control-point is updated to a
> newer version of libgupnp. For us it means that customers would have to
> update all devices at the same point. Other vendors using gupnp will run
> into similar problems. So I suggest that the redundant loop over all
> children of a property is reintroduced together with a comment stating
> that this is for backward-compatibility with gupnp 0.12.

  I agree but the other reason to remove that loop was to make the
very ugly code somewhat readable.  So Ross, please don't just revert
yet, I promise to provide a cleaner patch this week. If I don't
full-fill my promise please do a simple revert then. :)

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124
--
To unsubscribe send a mail to gupnp+unsubscribe\@o-hand.com