Re: autorun.inf and .xdg-volume-info

[Matthias Clasen <matthias clasen gmail com>]

On Sun, Mar 1, 2009 at 11:08 PM, David Zeuthen <david fubar dk> wrote:
> On Sun, 2009-03-01 at 23:00 -0500, David Zeuthen wrote:
>> On Thu, 2009-02-26 at 19:37 -0500, David Zeuthen wrote:
>> > Attached is an updated patch that fixes up the error handling in
>> > on_autorun_loaded(). It also adds two TODO items to mark two strings for
>> > translation (and explains that these strings are not currently used by
>> > anyone).
>>
>> And here is another updated version that
>>
>>  - uses "Name" and "Icon" instead of "name" and "icon" for the key
>>    names (same as .desktop files)
>>
>>  - allows either Name or Icon or both (or none of them) to be set
>>    in the .xdg-volume-info file; the previous patch required both
>>    of them to be set
>

Trivial typo spotted in passing: s/translatation/translation/ in several places


+          icon = g_themed_icon_new (icon_name);
+          g_themed_icon_append_name (G_THEMED_ICON (icon),
"drive-removable-media");
+          g_themed_icon_append_name (G_THEMED_ICON (icon), "drive-removable");
+          g_themed_icon_append_name (G_THEMED_ICON (icon), "drive");

Could save a line here by using
g_themed_icon_new_with_default_fallbacks +
g_themed_icon_prepend_name...


Feels to me like there should be some documentation somewhere about
.xdg-volume-info. Not sure where to put that, exactly...