Re: idle inspector broke screensaver? wtf

[Toms <toms baugis gmail com>]

Peh, now i have to use the brains!

First about the breakage - there is something curious about D-Bus and
listeners and if it does not get what it expects, it dies or
something. In this case - returning both False and True broke it and
it was specifically waiting for None. Bug can be easily reproduced
[1].

A good citizen could file a bug where appropriate. There are some
mighty people in launchpad already with fierce opinions [2], so I let
them to fix all the wrongoings when they will get time for that.

Line 77, on the other hand, is required for introspection to work
(like introspectible via d-feet). And, who, knows, potentially yes, it
might break other interfaces.

Although current solution is a bit tangled, it seems to work. I of
course would appreciate if anybody would get to root of this, and
maybe, while on it, put all the d-bus stuff in single place.

Thanks for keeping an eye!
Toms

[1] https://bugzilla.gnome.org/show_bug.cgi?id=600909
[2] https://bugs.launchpad.net/ubuntu/+source/hamster-applet/+bug/448438/comments/22



On Tue, Dec 15, 2009 at 3:58 PM, Uri Okrent <uokrent gmail com> wrote:
> Hey Toms, I got my latest updates from ubuntu this morning and saw in
> the notes that there was a bug in hamster that was messing up screen
> saver inhibition. That piqued my curiosity because I wrote the first
> patch for hamster that apparently caused the problem. I don't really
> get why snooping on the dbus messages for the "Lock" method would
> break things, but anyway...
>
> The reason I'm emailing the list is, I see you pushed f5678d58 to fix
> the issue. My question is, if that's the problem, wouldn't the return
> value of True on hamster/idle.py:77 potentially cause the same issue
> with some other interface (not hamster or screensaver)?
>
> --
>   Uri 瓜
>
> Please consider the environment before printing this message.
> http://www.panda.org/how_you_can_help/
> _______________________________________________
> hamster-applet-devel-list mailing list
> hamster-applet-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/hamster-applet-devel-list
>