Re: [PATCH] Fix stale git status



<snip>

> While it shouldn't really make much difference, I think it would be
> better to avoid os.system() and use _vc.popen() for the sake of
> consistency.

Thanks for the feedback.  I'll resubmit the change.

>> Also, is it preferred to "hide" all subprocesses output so that
>> nothing is printed when meld is ran from the command line?  Eg right
>> now I see the following:
>> $ ./bin/meld ./
>> (I click on the git.py file in the meld GUI)
>> patching file meld/vc/git.py
>> (I click on the _vc.py file in the meld GUI)
>> patching file meld/vc/_vc.py
>>
>> Is the "patching file xyz" command line output intentional, a bug, or
>> just some output no one cares about either way?
>
> I think it's some output no one cares about, so it really should go
> away. A patch that gets rid of it would be greatly appreciated.

I'll look into changing this behavior.

Best,
Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]