Re: [PATCH 1/2] Update git to use "git diff-index" instead of "git status"
- From: Kai Willadsen <kai willadsen gmail com>
- To: Peter Tyser <ptyser gmail com>
- Cc: meld-list gnome org, grant b edwards gmail com
- Subject: Re: [PATCH 1/2] Update git to use "git diff-index" instead of "git status"
- Date: Tue, 2 Mar 2010 18:19:29 +1000
On 2 March 2010 16:16, Peter Tyser <ptyser gmail com> wrote:
>>> Sorry for the long-winded email. Long story short, I think the
>>> current patch is an improvement as is. I won't resubmit unless
>>> someone sees a flaw in the logic above.
>>
>> While I'd like a definitive answer on the rename/copy detection, I'm
>> inclined to agree. I'll probably poke it a little bit more and then
>> push. Thanks.
>
> I finally get it:) I can't affect "git diff-index"'s copy/rename
> detection via my .gitconfig either. I added some quick debug to the
> git diff-index command and it looks like it never takes the git config
> parameter "diff.renames" into consideration. The "diff.renames"
> parameter only seems to affect the git commands which use the
> git_diff_ui_config() function (eg commit, diff, log, and merge).
Fair enough, and thanks for following it up. I've pushed these patches.
cheers,
Kai
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]