Re: wine's fullscreen code has no effect on metacity

["Elijah Newren" <newren gmail com>]

On 7/6/06, Havoc Pennington <hp redhat com> wrote:
> Look at src/window.c:recalc_window_features() for possible reasons
> metacity decided to disable fullscreenability.
>
> In this case it looks pretty clear though - the firefox window isn't
> resizable, metacity disables fullscreen in that case unless the window
> size is equal to the screen size and the window is not decorated.
>
> It looks like 1280x1024 could be your screen size, so my guess is that
> the window has a frame on it.
>
> I don't really know why the !window->decorated is in the check in
> recalc_window_features but Elijah may well.

Nope, but I found this:
2002-08-15  Havoc Pennington  <hp pobox com>

       * src/window.c (recalc_window_features): leave has_fullscreen_func
       set to TRUE if the window is screen sized and undecorated, even if
       the window isn't resizable. idea from Christian - Manny Calavera -
       Neumair
You didn't state a bug number or anything, so no more details appear
to be available.  I also don't see why the decoration check is there,
but the fact that it is would explain why subsequent "fullscreen me"
messages from the app would be ignored.

As Rob pointed out, there are also some heuristics in src/stack.c (see
window_is_fullscreen_size()) to try to treat certain windows as
fullscreen despite their incorrect methods at attempting to fullscreen
themselves (such as what these windows apps with wine are apparently
doing).  These heuristics, at least at first glance, also look broken
to me in the case of windows with decorations since constraints will
force the client area of the window away from the upper left corner of
the workarea.  (This appears to be true for both the old
metacity-2.12.x version and the current one)