Re: wine's fullscreen code has no effect on metacity

[Havoc Pennington <hp redhat com>]

Dmitry Timoshkov wrote:
> "Havoc Pennington" <hp redhat com> wrote:
>
> > Dmitry Timoshkov wrote:
> > > It's OK that a WM constrains windows to be placed inside of its work 
> > > area
> > > but still allows to place them into a fullscreen state on request. 
> > > How would
> > > you suggest to properly inform a WM that a window needs to be in a 
> > > fullscreen
> > > state? Does metacity ignore ClientMessage/_NET_WM_STATE_FULLSCREEN 
> > > request due
> > > to 'fullscreenable = 0' or something else?
> >
> > I'm not next to the machine where I had the log unpacked, so I'm not 
> > sure, but yeah if fullscreenable=0 when the client message is received 
> > then that would cause it to be ignored. I think some tweaking to when 
> > fullscreenable is set would be well worth trying out as a solution.
>
> Anything else I can do to help fixing this problem? Do you need any further
> testing/logs/investigation on the Wine side?

You could try patching metacity with either of the fixes mentioned here 
(or some other fix) and verify that they work for wine:
http://bugzilla.gnome.org/show_bug.cgi?id=346927

They are both basically 1-2 line changes, so there's no patch there but 
there should be enough info to easily patch metacity.

The other thing to test I guess is whether apps like e.g. mplayer/xine 
still get heuristically fullscreened, though for all I know recent 
mplayer uses the proper hints now.

It's best to add further info on the bug so it doesn't get lost.

Havoc