Re: [mousetrap-list] Missing DESTDIR in Makefile.am

[Flaper87 <flaper87 gmail com>]

I applied the patch and pushed the changes.

Please create the bug ticket anyway so I can have track of this.

Thanks a lot

2010/3/30 Flaper87 <flaper87 gmail com>

Hi Samuel,

I'm sorry for my late answer...

Could you please open a bug in the MouseTrap bugzilla and submit the patch there???

The other 2 bugs were fixed before I read your emails so please create a bug just for this one....

Thanks a lot, I'll apply your patch

2010/3/19 Samuel Thibault <samuel thibault ens-lyon org>

Hello,

Some Makefile.am files are missing the $(DESTDIR) part, here is a patch.

Samuel

diff --git a/src/mousetrap/Makefile.am b/src/mousetrap/Makefile.am
index bef25f7..a65920e 100644
--- a/src/mousetrap/Makefile.am
+++ b/src/mousetrap/Makefile.am
@@ -8,4 +8,4 @@ SUBDIRS = app ocvfw
 mousetrap_pythondir=$(pyexecdir)/mousetrap/

 install-exec-hook:
-       chmod a+rx $(mousetrap_pythondir) -R
+       chmod a+rx $(DESTDIR)$(mousetrap_pythondir) -R
diff --git a/src/mousetrap/app/Makefile.am b/src/mousetrap/app/Makefile.am
index 7bf30bb..452dda0 100644
--- a/src/mousetrap/app/Makefile.am
+++ b/src/mousetrap/app/Makefile.am
@@ -18,4 +18,4 @@ SUBDIRS = lib ui addons
 mousetrap_pythondir=$(pyexecdir)/mousetrap/app

 install-exec-hook:
-       chmod a+rx $(mousetrap_pythondir) -R
+       chmod a+rx $(DESTDIR)$(mousetrap_pythondir) -R
diff --git a/src/mousetrap/ocvfw/Makefile.am b/src/mousetrap/ocvfw/Makefile.am
index b846a67..d9a759c 100644
--- a/src/mousetrap/ocvfw/Makefile.am
+++ b/src/mousetrap/ocvfw/Makefile.am
@@ -13,4 +13,4 @@ SUBDIRS = dev haars idm
 ocvfw_pythondir=$(pyexecdir)/mousetrap/ocvfw

 install-exec-hook:
-       chmod a+rx $(ocvfw_pythondir) -R
+       chmod a+rx $(DESTDIR)$(ocvfw_pythondir) -R
_______________________________________________
mousetrap-list mailing list
mousetrap-list gnome org
http://mail.gnome.org/mailman/listinfo/mousetrap-list

--
Flavio Percoco Premoli, A.K.A. [Flaper87]
http://www.flaper87.org
Usuario Linux registrado #436538
Geek by nature, Linux by choice, Archer of course.
Key Fingerprint: CFC0 C67D FF73 463B 7E55  CF43 25D1 E75B E2DB 15C7
The Solution to everything:
python -c "from struct import pack; print  pack('5b', (41*len('99')), pow(8,2)+20, 4900**0.5, range(78)[-1], 10)"

--
Flavio Percoco Premoli, A.K.A. [Flaper87]
http://www.flaper87.org
Usuario Linux registrado #436538
Geek by nature, Linux by choice, Archer of course.
Key Fingerprint: CFC0 C67D FF73 463B 7E55  CF43 25D1 E75B E2DB 15C7
The Solution to everything:
python -c "from struct import pack; print  pack('5b', (41*len('99')), pow(8,2)+20, 4900**0.5, range(78)[-1], 10)"