Re: [Nautilus-list] PATCH: eel gcc'isms

[Laszlo PETER <Laszlo Peter ireland sun com>]

Darin Adler wrote:

> > -EelDimensions
> > +const EelDimensions
> > eel_gdk_pixbuf_get_dimensions (const GdkPixbuf *pixbuf)
> > {
> 
> > /* Access the dimensions of a pixbuf. */
> > -EelDimensions        eel_gdk_pixbuf_get_dimensions            (const
> > GdkPixbuf       *pixbuf);
> > +const EelDimensions  eel_gdk_pixbuf_get_dimensions            (const
> > GdkPixbuf       *pixbuf);
> 
> These are acceptable, I guess, but they do not look like great changes to
> me. Can you omit these and fix problems related to these another way?

Yes, I can omit these and add this one instead:

diff -u -r1.16 eel-debug-drawing.c
--- eel-debug-drawing.c	9 Nov 2001 01:43:49 -0000	1.16
+++ eel-debug-drawing.c	7 Dec 2001 11:14:37 -0000
@@ -125,9 +125,11 @@
 	
 	viewer = DEBUG_PIXBUF_VIEWER (widget);
 
-	dimensions = (viewer->pixbuf != NULL) ?
-		eel_gdk_pixbuf_get_dimensions (viewer->pixbuf) :
-		eel_dimensions_empty;
+	if (viewer->pixbuf != NULL) {
+		dimensions = eel_gdk_pixbuf_get_dimensions (viewer->pixbuf);
+	} else {
+		dimensions = eel_dimensions_empty;
+	}
 	
    	requisition->width = MAX (2, dimensions.width);
    	requisition->height = MAX (2, dimensions.height);

Laca