Re: [Nautilus-list] [PATCH]: Avoid directory reload when FAM is active.

[Yoann Vandoorselaere <yoann mandrakesoft com>]

Darin Adler <darin bentspoon com> writes:

> On Sunday, June 17, 2001, at 05:11  AM, Yoann Vandoorselaere wrote:
> 
> > +        use_monitoring = nautilus_monitor_active ();
> 
> Just checking if the monitor is active is not enough. You also have to
> check that the directory in question is a "file://" directory and not
> another kind of URL. Also, you have to explicitly check that this is
> not the reload case, since reload won't actually do any reloading
> without the code, and we do want reload to cause a reload even with
> the file monitoring on. So we need 3 checks, not just this single one.

There is no need for a third check...
You just need to add a nautilus_directory_force_reload() in 
nautilus_window_reload().


> PS: I know this is going to drive Yoann nuts, but I started working on
> this fix myself after the discussion last week -- I had forgotten that
> Yoann said he would do it. I probably have the fix done correctly, but
> I haven't had a chance to check it in, and won't have a chance to do
> it until I return from my trip.

That's the second time it happen.
Next time you'll take a note, or you forget about me.

That kind of issue forbid me to learn, because I code the whole
fix without you doing it. It make me lost my time. And it is very
offending.

-- 
Yoann Vandoorselaere | One luser tried to change his password on Mandrake. Not
MandrakeSoft         | having any imagination at all, he entered "penis" for a
                     | password... He got the following answer:   BAD PASSWORD:
                     | it is too short