Re: [Nautilus-list] [PATCH] Make EelTextCaption behave properly inpreferences

[Darin Adler <darin bentspoon com>]

On Saturday, May 19, 2001, at 04:47  PM, Miguel Rodríguez Pérez wrote:

> Please ignore my previous patch, it works fine, but it can be done much 
> simpler...

The concept of this patch is good.

To match Nautilus style guidelines, it needs to do "strcmp (xxx, yyy) == 0"
 rather than "!strcmp(xxx, yyy)". Note both the space after the name of 
the function before the parenthesis, and use of == 0 with strcmp, not !. 
Also, the single statement inside the if needs to be surrounded by braces 
as described in the style guide document (nautilus/doc/style-guide.html).

If you fix these minor style issues, it would be fine to commit this 
change.

    -- Darin