[Nautilus-list] Re: More Gnome 2 Work

[Darin Adler <darin bentspoon com>]

Great work! I have a few questions:

> +#ifdef GNOME2_CONVERSION_COMPLETE
> gnomelib_register_popt_table (bonobo_activation_popt_options,
> bonobo_activation_get_popt_table_name ());
> orb = bonobo_activation_init (argc, argv);
> 
> @@ -97,13 +100,17 @@
> /* initialize gnome-vfs, etc */
> g_thread_init (NULL);
> gnome_vfs_init ();
> +#endif
> +    bonobo_ui_init ("nautilus-hardware-view", VERSION, &argc, argv);
> 
> +    /* FIXME 
>        registration_id = bonobo_activation_make_registration_id
> ("OAFIID:nautilus_hardware_view_factory:8c80e55a-5c03-4403-9e51-3a5711b8a5ce",
> -                            getenv ("DISPLAY"));
> -    factory = bonobo_generic_factory_new_multi (registration_id,
> +                            getenv ("DISPLAY"));*/

Please don't put in FIXME without a comment that explains what needs to be
fixed. In this particular case, I think you want a
GNOME2_CONVERSION_COMPLETE ifdef instead, because we need the
display-specific factory handling in here.

> -    g_free (registration_id);
> +    /*g_free (registration_id);*/

Again, we want the ifdef GNOME2_CONVERSION_COMPLETE, not commented-out code,
because we won't remember to go back.

> +/* FIXME */
> +#include <bonobo/bonobo-property-bag.h>

Another FIXME with no comment. What's to fix here, anyway? It's fine to
include a header.

> -        g_signal_connect (retval, "destroy",
> -                    do_destroy, NULL);
> +        g_signal_connect (G_OBJECT (retval), "destroy",
> +                    G_CALLBACK (do_destroy), NULL);

No typecasts for the first parameter to g_signal_connect. I went to some
trouble to remove those, so please don't add them back in.

> factory =
> -        bonobo_generic_factory_new_multi (registration_id, make_obj,
> +        bonobo_generic_factory_new (registration_id, make_obj,
>  NULL);

If you were able to keep the DISPLAY-specific IID in this case, why did you
remove it in the other cases?

Do you have cvs access, or do you need me to commit your changes?

    -- Darin