[Nautilus-list] Re: [GNOME VFS] start-here: etc. vfs method



On Thu, Sep 20, 2001 at 06:53:36PM -0400, Havoc Pennington wrote:
> 
> Ian McKellar <yakk eavel com> writes: 
> > Why do you have a separate conf file for this? Is it nececary?
> 
> No, I just thought it was more aesthetically pleasing since there are
> 6 entries for the libdesktop.so. I'm happy to go either way.

I would personally prefer to simply add them to the main conf file. Less
files is simpler I guess.
> 
> > >  
> > > Index: modules/desktop-method.c
> > > ===================================================================
> > (snip)
> > > +
> > > +#define G_N_ELEMENTS(arr)		(sizeof (arr) / sizeof ((arr)[0]))
> > 
> > Is this macro going to be in GLib2? If its not part of a glib I would
> > rather it not have it use the G_ prefix.
> 
> The idea is that on GLib upgrade, the compiler dies on this, and we
> simply replace it. 

Great. Thats good then.
> 
> > Other than that it looks good. Do you think you'll have a chance to make a
> > patch against HEAD too?
> 
> Yes, I plan to commit to HEAD as well (will the patch have to change
> significantly?)

That should apply against HEAD without any significant changes. Go ahead when
you're ready.

Ian




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]