Re: [Nautilus-list] [PATCH] for bug 43302

[Alex Larsson <alexl redhat com>]

On Tue, 23 Apr 2002, Gaute Lindkvist wrote:

> This fixes all the issues you mentioned. The patch look better as well. It
> is however a new string in this, as you suggested. That might need
> approval.

Take out the:
+    g_print ("Unsupported mime-type: %s\n", mime_type);

You don't need to use eel_strcmp, since you know mime_type != NULL.

There are several places where you are missing a space before the 
parenthesis in function calls.

We do:
 if (foo) {
 } else {
 }
Not:
 if (foo) {
 }
 else {
 }


+		if (status < 0) {
+			return NAUTILUS_THEME_INSTALL_FAILED;
+		}
+		else if (status != 0) {
+			return NAUTILUS_THEME_INSTALL_FAILED;
+		}
The first if seems unnecessary.


You also have to move the creation of the user themes directory above the 
handling of tar:ed themes.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a jaded devious househusband on the hunt for the last specimen of a great 
and near-mythical creature. She's a disco-crazy mute college professor on her 
way to prison for a murder she didn't commit. They fight crime!