[Nautilus-list] Bug #73456

[Damon Chaplin <damon ximian com>]

This is a crash that occurs when Corba connections have died:

http://bugzilla.gnome.org/show_bug.cgi?id=73456

The patch checks the Corba ev and returns the default value if the Corba
call failed.

That avoids the SEGV, though I'm not sure what the overall
error-handling strategy is in nautilus.

Damon

Index: nautilus-directory-metafile.c
===================================================================
RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-directory-metafile.c,v
retrieving revision 1.46
diff -u -r1.46 nautilus-directory-metafile.c
--- nautilus-directory-metafile.c	8 Mar 2002 19:43:43 -0000	1.46
+++ nautilus-directory-metafile.c	25 Apr 2002 20:05:56 -0000
@@ -203,7 +203,12 @@
 
 	corba_value = Nautilus_Metafile_get (get_metafile (directory), file_name, key, non_null_default, &ev);
 
-	/* FIXME bugzilla.gnome.org 46664: examine ev for errors */
+	if (ev._major != CORBA_NO_EXCEPTION) {
+		g_warning ("Failed to get file metadata.");
+		CORBA_exception_free (&ev);
+		return g_strdup (default_metadata);
+	}
+
 	CORBA_exception_free (&ev);
 
 	if (eel_str_is_empty (corba_value)) {