Re: Patch for bug 82780 - Thumbnails are flat



On 24 Jun 2002, Damon Chaplin wrote:

> 
> Hi, I've added a patch to:
> 
>    http://bugzilla.gnome.org/show_bug.cgi?id=82780
> 
> 
> load_icon_from_path() was checking for the wrong path:
> 
> -	if (strstr (path, "/.thumbnails/") != NULL) {
> +	if (strstr (path, "/.nautilus/thumbnails/") != NULL) {
 
This patch looks good.
 
> However, small images (<16K or something similar) are used as-is,
> and so won't be in the thumbnails directory. So they won't have the
> border added. Was nautilus 1.4 like that?

I'm not sure, but I'd guess so, since 1.4 stored the border in the 
thumbnail files.
 
> I don't know if there is a more reliable way to check if it should have
> a border.

There seems to be no simple way. It would require some changes to the icon 
loader it seems.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a scrappy zombie master criminal with a robot buddy named Sparky. She's a 
cosmopolitan punk angel who inherited a spooky stately manor from her late 
maiden aunt. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]