Re: PATCH: use local path when dropping files onto icons

[Alexander Larsson <alexl redhat com>]

On Mon, 24 Jun 2002, Frank Worsley wrote:

> > Yeah, i know this, but after you changed it to not use _is_local it would 
> > work. Anyway, it's not important, i was just wondering if there was 
> > something i missed.
> 
> Nah, it still wont work because of escaped characters. A path with
> spaces would become 'a%20path%20with%20spaces'.
> 
> Here's the revised patch. Did a bunch of work on the previous stuff and
> the treeview now also works for viewing/launching files.

Looks good except for this:
+       } else if (uri != NULL
+                  && nautilus_file_is_executable (file)
+                  && nautilus_file_can_execute (file)
+                  && nautilus_file_is_local (file)) {  

You can't use is_local here, since that means you can't start apps from 
NFS directories. (In fact, since it's completely unspecifed what is_local 
means i'd say any use of it is broken.) I'd hate to add another has_prefix 
("file:") though, maybe we should add a 
EEL_VFS_TEST_IS_MOUNTED_FILESYSTEM to eel_vfs_test_capabilities.



-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a hate-fuelled arachnophobic grifter in a wheelchair. She's a 
manipulative hypochondriac Hell's Angel with someone else's memories. They 
fight crime!