Re: patch for #83964

[jacob berkman <jacob ximian com>]

On Thursday, October 3, 2002, at 07:09  AM, Alexander Larsson wrote:

> On 2 Oct 2002, jacob berkman wrote:
>
> > On Wed, 2002-10-02 at 03:12, Jeff Waugh wrote:
> > > <quote who="jacob berkman">
> > >
> > > > > It also doesn't work with Link type .desktop files (perhaps 
> > > > > Command -> URL
> > > > > for these?)
> > > >
> > > > fixed.
> > > >
> > > > alex, dave?  thoughts?
> > >
> > > The only remaining oddness that I can see is that you can't switch 
> > > the type
> > > to Application.
> >
> > hmm somehow that got left off.  also i had forgotten to add the code 
> > to
> > actually change the type.
>
> Some general comments:
>
> Switching types seems a bit busted. It's frequently very slow, and
> sometimes it doesn't work att all after a while (the menu keeps
> disappearing each time you pop it up.)

i don't quite get what you mean here - if you put a g_print() in 
ditem_file_changed(), is it getting called a lot?

> I don't think we really want to expose all the crack desktop file 
> types in
> a general desktop file editor. Only Application and Link, and possibly
> FSDevice (but we should not call it that).

(hmm, i'm not even sure what FSDevice is)

> It doesn't seem done yet ui-wise. Only Application and Link have
> reasonable UI for editing, and even Link has some issues (It still has 
> the
> run in terminal checkbox).

ok, this is easy enough to change.

> +	/* We always create it, but it is hidden
> +	 * when the file is not a ditem
> +	 */
> +	create_launcher_page (window);
> +	
>
> Why do you do this? It would seem better to only create the page when 
> it
> is needed.

to handle the case where target_file changes under you, either to or 
from a .desktop file.

 - jacob