Re: [PATCH] Another GDK_ACTION_ASK Related Bug



Apparently, the break statement was placed there to prevent mozilla from creating two links for
every url dropped onto the desktop, so I put the break statement back but check for a null path
before executing it.  Attached is another suggested patch.  

--- Dennis Cranston <dennis_cranston yahoo com> wrote:
> Hi,
> 
> Here is another nautilus problem that I found using the GDK_ACTION_ASK drag action in
> gnome-search-tool, the 'Link here' option does not support multiple files.  For example, if I
> drag
> two or more files from the search results window in gnome-search-tool to the desktop and select
> the 'Link here' option, nautilus creates a link for one file.  I am attaching a proposed patch.
> 
> The code changed is in nautilus/src/file-manager/fm-icon-view.c.  The problem is that Nautilus
> starts a for loop to create a link for each of the uris in the uri list, but there is a break
> statement at the end of the for loop.  So, the first link is created and all others are ignored.
>  
> 
> BTW, I changed the code to pass a NULL for GdkPoint rather than the same (x,y) position for each
> uri.  This prevents the links from be created on top of each other.  
> 
> Thanks,
> Dennis

Attachment: fm-icon-view.diff
Description: fm-icon-view.diff



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]