Re: [PATCH] gnome-vfs: Don't monitor read-only filesystems

[Frederic Crozat <fcrozat mandrakesoft com>]

Le mer 07/04/2004 à 10:55, Alexander Larsson a écrit :
> On Mon, 2004-04-05 at 11:41, Frederic Crozat wrote:
> > tt de Le ven 06/02/2004 à 14:43, Alexander Larsson a écrit :
> > > On Mon, 2004-01-26 at 17:13, John McCutchan wrote:
> > > > On Mon, Jan 26, 2004 at 09:18:54AM +0100, Alexander Larsson wrote:
> > > > > Hmmm. Nautilus already does this. However, there was a race condition on
> > > > > mount which made this not always work, which i fixed last week.
> > > > > 
> > > > > Maybe the check makes more sense in gnome-vfs than nautilus though,
> > > > > since other apps can monitor stuff. I'm not sure about returning an
> > > > > error though. Nautilus just makes a monitor that never signals any
> > > > > change.
> > > > 
> > > > I think it makes more sense in gnome-vfs, the recent-files stuff
> > > > monitors all files in the list, which causes problems when unmounting
> > > > cdroms. I am not that familiar with gnome-vfs code, what result should
> > > > the code return in this situation?
> > > 
> > > It should succeed and never send any change events. Thats the same
> > > semantics as now, only using less effort and not hogging the cdrom. Of
> > > course, this adds an extra couple of stats to each monitor, so monitor
> > > creation performance is down.
> > 
> > I was just wondering what was the status of this patch ?
> > 
> > It doesn't seem to have been pushed in 2.6.
> 
> No, but similar code is already in Nautilus [see
> nautilus-monitor.c:monitor_add_internal()]. I'm not sure putting it in
> gnome-vfs for all monitor uses is a good idea. It imposes a quite heavy
> performance hit (stat per monitor + need to connect to the daemon for
> the volume monitor) for things that rarely need this. And it doesn't
> even really "solve" anything. If an app leaves monitors around it'll
> still mean you can't unmount the volume, and this needs fixing anyway.

Well, it is still a problem because of monitoring on recent-files :
-try to run an audio file from a CDROM with totem
-the file will be added to recent-files and will be monitored.
-therefore, you won't be able to eject the CD, unless fam is killed..

This is why the nautilus stuff isn't sufficient..

And I haven't yet tested with removable drives (usb storage, memory
sticks) which have similar issues.

-- 
Frederic Crozat <fcrozat mandrakesoft com>
Mandrakesoft