Re: [PATCH] improvement for nautilus desktop

[Alexander Larsson <alexl redhat com>]

On Mon, 2004-04-05 at 15:21, Davyd Madeley wrote:
> (this is a retry, I think the original got stuck in the moderator queue).
> 
> Opened bug #138930 (http://bugzilla.gnome.org/show_bug.cgi?id=138930) to
> add a gconf key for Nautilus making it possible to hide mounted volumes
> from the desktop.
> 
> I think this is a relevant feature for Nautilus, especially for those of
> us who like really empty desktops. Also, it goes hand in hand with the
> keys to hide Home, Computer and Trash.
> 
> There are still a few bugs in the patch (two I've found). Both of these
> seem to be NULL-reference glitches. However I'm posting the patch now
> because maybe someone else can track them down faster.
> 
> Patch is available from bugzilla or
> http://davyd.angrygoats.net/nautilus-patch.diff
> 
> A screenshot showing what I'm trying to achieve is
> http://davyd.angrygoats.net/images/nautilus-patch.png

I commented on the patch in the bug. With some fixed it looks ok.
However, it breaks the string freeze, so it can't go in until we branch,
and i don't want to do that just yet.

Also, please use "cvs diff -up" to generate patches, that makes them
easier to review. Just add a "diff -up" line to ~/.cvsrc.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a superhumanly strong zombie waffle chef with a mysterious suitcase 
handcuffed to his arm. She's a cold-hearted snooty former first lady on the 
trail of a serial killer. They fight crime!