Re: [PATCH] Hide clean up by name

[Alexander Larsson <alexl redhat com>]

On Mon, 2004-08-30 at 15:20, Jaap Haitsma wrote:
> > On Mon, 2004-08-30 at 12:17, Jaap Haitsma wrote:
> >> > On Sun, 2004-08-29 at 18:18, Jaap Haitsma wrote:
> >> >> "Cleanup by Name" is also in the context menu when you right click on
> >> a
> >> >> spatial window or the file browser. It is then always disabled. To
> >> >> reduce clutter, this little patch just hides it.
> >> >
> >> > Its not always disabled. Its enable when the window/folder is in
> >> manual
> >> > layout mode.
> >> >
> >> I think hardly any people only use that mode for browsing there files.
> >> IMHO it's better to hide it then to avoid cluttering the context menu
> >> which is already very crowded.
> >
> > The folder context menu is hardly "very crowded". I don't see the gain
> > of removing features to make it smaller.
> >
> Maybe you misunderstood me. My patch is *not* removing the feature. It
> will be present when it is manual layout mode. You just won't see it when
> your in automatic layout.

Its typically considered bad ui when the menu for a specific context
contains different items depending on some state. The normal thing to do
then is to use insensitive menu items. I'm sure the HIG has something to
say on this.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an ungodly pirate gangster on a mission from God. She's a wealthy gypsy 
wrestler with a knack for trouble. They fight crime!