Re: eel code freeze break request

["Murray Cumming" <murrayc murrayc com>]

Approval 1 of 2. Thanks. I hope that lots of testers reported this.

> When you add or remove new applications to the open with property page
> in nautilus the new application doesn't appear/disappear until you close
> and reopen the page. The following patch fixes this, and removes some
> spew:
>
> Index: eel/eel-mime-application-chooser.c
> ===================================================================
> RCS file: /cvs/gnome/eel/eel/eel-mime-application-chooser.c,v
> retrieving revision 1.3
> diff -u -p -r1.3 eel-mime-application-chooser.c
> --- eel/eel-mime-application-chooser.c	23 Jul 2004 16:20:18 -0000	1.3
> +++ eel/eel-mime-application-chooser.c	31 Aug 2004 13:57:10 -0000
> @@ -282,16 +282,11 @@ static void
>  mime_monitor_data_changed_cb (GnomeVFSMIMEMonitor *monitor,
>  			      gpointer user_data)
>  {
> -#if 0
>  	EelMimeApplicationChooser *chooser;
> -
> +
>  	chooser = EEL_MIME_APPLICATION_CHOOSER (user_data);
>
> -	g_print ("refreshing model\n");
> -
>  	refresh_model (chooser);
> -	g_print ("done refreshing the model\n");
> -#endif
>  }
>
>  static void
> Index: eel/eel-mime-extensions.c
> ===================================================================
> RCS file: /cvs/gnome/eel/eel/eel-mime-extensions.c,v
> retrieving revision 1.4
> diff -u -p -r1.4 eel-mime-extensions.c
> --- eel/eel-mime-extensions.c	12 Aug 2004 11:50:18 -0000	1.4
> +++ eel/eel-mime-extensions.c	31 Aug 2004 13:57:10 -0000
> @@ -163,9 +163,7 @@ mime_update_program_done (GPid     pid,
>  		/* FIXME: what is the right thing to do here??  We're going to
>  		 * have to rethink the gnome-vfs APIs.
>  		 */
> -		g_print ("updating the database\n");
>  		gnome_vfs_mime_reload ();
> -		g_print ("done updating\n");
>  	}
>  }
>
> The patch is interesting in that it mostly removes an "#if 0" statement.
> I'm not sure why it was there at all. It was in the initial checking by
> dave, but he has no idea why its there either.


Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com