Re: [PATCH] Crash renaming empty selection (#131861)

[Alexander Larsson <alexl redhat com>]

On Sat, 2004-02-07 at 05:17, Martin Wehner wrote:
> On Fri, 2004-02-06 at 19:22 -0800, Darin Adler wrote:  
> > Shouldn't the nautilus_file_list_free (selection) line be outside the 
> > if to avoid a storage leak?
> > 
> >      -- Darin
> 
> Hi Darin,
> 
> well I don't think it actually leaks anything because it only doesn't
> free when selection == NULL. But in all other instances where
> empty_selection() is used, file_list_free() is outside the if block and
> called on potentially empty selections.
> So I guess it should be outside in this instance too. Should I update it
> accordingly?

It doesn't hurt being consistent. So please change that.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a globe-trotting flyboy librarian on the wrong side of the law. She's an 
enchanted extravagent safe cracker fleeing from a Satanic cult. They fight 
crime!