[PATCH] Proposed renaming of "Open With Other Application..." label

[Christian Neumair <chris gnome-de org>]

The attached patch is meant to improve the "Open With Other
Application..." label by either using "Other Application..."
if the label is displayed inside the "Open With" submenu or using "Open
With..." if it is directly displayed inside the popup (cp. [1], [2]).

I'm convinced that "Open With"->"Open With Other Application" sounds
rather stupid, because "Open With" is displayed twice. Therefore I've
changed it to "Other Application..." in that case.
But the confinement "Other Application" is in my opinion obsolete,
because that action doesn't neccessarily mean that you actually use
*another* application, but simply select what application you want. So
I've decided to use "Open with..." for the main menu. Unfortunately,
that applies for the submenu as well ("Open with"->"Open with..." is
weird). So maybe I can change the "Other Application..." from the patch
into "Select...".
Any proposals?

Note that I've already committed the attached patch some days ago and
was asked to revert it.

regs,
 Chris


[1] http://www.gnome.org/~jrb/files/mime/context-open-other.png
[2] http://www.gnome.org/~jrb/files/mime/context-open-common.png

Index: src/file-manager/fm-directory-view.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/file-manager/fm-directory-view.c,v
retrieving revision 1.629
retrieving revision 1.630
diff -u -r1.629 -r1.630
--- src/file-manager/fm-directory-view.c	22 Jul 2004 03:57:44 -0000	1.629
+++ src/file-manager/fm-directory-view.c	24 Jul 2004 09:49:50 -0000	1.630
@@ -3922,6 +3922,13 @@
 		submenu_visible = (num_applications > 3);
 	}
 
+	/* This label is either displayed inside the submenu, or below the other open with entries */
+	nautilus_bonobo_set_label (view->details->ui,
+				   FM_DIRECTORY_VIEW_COMMAND_OTHER_APPLICATION,
+				   submenu_visible
+				   ? _("_Other Application...")
+				   : _("Open _With..."));
+
 	/* It's OK to set the visibility of the menu items (rather than the verbs)
 	 * here because these are submenu titles, not items with verbs.
 	 */
Index: src/file-manager/nautilus-directory-view-ui.xml
===================================================================
RCS file: /cvs/gnome/nautilus/src/file-manager/nautilus-directory-view-ui.xml,v
retrieving revision 1.66
retrieving revision 1.67
diff -u -r1.66 -r1.67
--- src/file-manager/nautilus-directory-view-ui.xml	22 Jul 2004 03:57:44 -0000	1.66
+++ src/file-manager/nautilus-directory-view-ui.xml	24 Jul 2004 09:49:50 -0000	1.67
@@ -37,7 +37,7 @@
          _label="_Open Scripts Folder"
 	 _tip="Show the folder containing the scripts that appear in this menu"/>
 	<cmd name="OtherApplication"
-         _label="Open with Other _Application..."
+         _label="_Other Application..."
 	 _tip="Choose another application with which to open the selected item"/>
 	<cmd name="Show Hidden Files"
          _label="Show _Hidden Files"
@@ -132,7 +132,7 @@
 				  verb="OpenAlternate"/>
 			<placeholder name="Applications Placeholder" delimit="top"/>
 			<submenu name="Open With" 
-				 _label="Open Wit_h" 
+				 _label="Open _With" 
 				 _tip="Choose a program with which to open the selected item">
 				<placeholder name="Applications Placeholder" delimit="none"/>
 				<separator/>
@@ -275,7 +275,7 @@
 			        verb="OpenAlternate"/>
 			<placeholder name="Applications Placeholder" delimit="top"/>
 			<submenu name="Open With" 
-				 _label="Open Wit_h" 
+				 _label="Open _With" 
 				 tearoff="0"
 				 _tip="Choose a program with which to open the selected item">
 				<placeholder name="Applications Placeholder" delimit="none"/>