Re: [PATCH] Directory view shutdown crash (#143561)



On Wed, 2004-06-02 at 09:57, Martin Wehner wrote:
> There's a small problem in the shutdown sequence in
> disconnect_model_handlers in fm-directory-view.c:
> nautilus_directory_file_monitor_remove will dispatch a state_changed
> signal, which will in turn call finish_loading etc., although the view
> is already in the process of being destructed. This will eventually
> crash in fm_list_model_get_sort_column_id_from_attribute over a null
> model pointer. This patch disconnects the callbacks before removing the
> directory monitor, which fixes the problem.
> Please see #143561 for instructions on how to reproduce the crash.

Looks great! Please commit on HEAD and gnome-2-6.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a short-sighted gay cowboy with no name. She's an elegant blonde widow 
living on borrowed time. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]