Re: Patch for bug #103802



On Sat, 2004-03-06 at 14:51, Julien Olivier wrote:
> Hi
> 
> I created a patch for bug #103802 (Fixing a "invalid unicode" filename
> causes "invalid" info to become part of filename).
> 
> I forward it here so that it doesn't get lost in bugzilla.

I'm not sure this is the right approach. We don't want to rely on string
matching like that (it'll be translated in other languages, and a real
filename *might* correctly contain that text). 

Also, why is the else part at the end duplicated three times?

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a witless moralistic cat burglar on the hunt for the last specimen of a 
great and near-mythical creature. She's a radical tomboy mechanic fleeing from 
a Satanic cult. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]