Re: desktop item editing

[Dave Camp <dave ximian com>]

On Fri, 2004-05-07 at 16:20 -0500, James Willcox wrote:
> Hey Dave,
> 
> Thanks for the review.  I think I fixed everything :)
> 
> James



> 
>         box = GTK_WIDGET (user_data);
>         item = gnome_desktop_item_new_from_string (g_object_get_data
> (G_OBJECT (box),
> 
> "uri"),
>                                                    file_contents,
>                                                    file_size,
>                                                    0, NULL);
> 
>         g_return_if_fail (item != NULL);
> 

This could probably be a runtime error, it should use if () rather than
g_return_if_fail().

Other than that it looks good to commit once we branch.  Should be
sometime pretty soon.

Thanks,
-dave



> -- 
> nautilus-list mailing list
> nautilus-list gnome org
> http://mail.gnome.org/mailman/listinfo/nautilus-list