Re: [PATCH] Bug #144803 Selected items not preserved correctly when list re-sorted

[Alexander Larsson <alexl redhat com>]

On Thu, 2004-09-30 at 19:46 -0700, Jimmy Do wrote:
> Hi everyone,
> 
> I've attached a patch which should fix the bug in Nautilus' list view
> where selected items aren't correctly preserved when clicking on
> different sort columns.
> 
> The problem was that the 'new_order' array wasn't being filled-in correctly.
> 
> I've already attached a patch to the bug report:
> http://bugzilla.gnome.org/show_bug.cgi?id=144803
> 
> It's my first patch, so please let me know if I need to make any changes. :)

Very good catch! I commited this to cvs. Thank you. 

Next time, don't leave unrelated changes like:
 	/* Let the world know about our new order */
-	path = gtk_tree_path_new ();
-
+	path = gtk_tree_path_new();
+	
+	

In the patch though. We use spaces before parenthesis in function call,
and minimizing unneeded whitespace changes makes it easier to track what
changed when in cvs.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a fast talking flyboy photographer from the 'hood. She's a cosmopolitan 
antique-collecting schoolgirl with an incredible destiny. They fight crime!