Re: patch : bug 42168 - Empty Trash confirmation should explain trash contents

[Alexander Larsson <alexl redhat com>]

On Mon, 2004-10-04 at 12:16 -0400, Vincent Noel wrote:
> Dennis Cranston attached a patch to bug 42168 to explain the trash
> content when asking for confirmation before emptying the trash. It
> looks really nice.
> A screenshot can be found here :
> http://bugzilla.gnome.org/attachment.cgi?id=32173&action=view
> 
> Link to the patch :
> http://bugzilla.gnome.org/attachment.cgi?id=32172&action=view

Its a nice idea. The patch doesn't seem ideal though.
It doesn't include all trashes, so it lies about the size of the trash.
It doesn't do a recursive size calculation, so it miscounts the size if
you have trashed directories. It does synchronous I/O which can block
the main thread and make poping up the trash dialog slow.

+		str = g_strdup ("If you empty the trash, the items will be permanently deleted.");

This string isn't translated.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an oversexed Jewish romance novelist on a search for his missing sister. 
She's a cosmopolitan punk widow with the power to bend men's minds. They fight 
crime!