Re: [PATCH] Neaten up the layout for text beside icons

[Iain * <iaingnome gmail com>]

Hmm, yes...
Do we want the text labels aligned, or the icons aligned?

iain

On Wed, 6 Oct 2004 11:24:14 -0400, Vincent Noel <vincent noel gmail com> wrote:
> The patch improves a lot the display in text-besides-icon, but the
> icons are vertically misaligned. When there's only a single column of
> icons it's kind of obvious (see the attached screenshot). Is this on
> purpose ?
> Note that even with the misalignment it's still better than before.
> 
> 
> 
> On Wed, 06 Oct 2004 11:07:14 -0400, Dave Camp <dave novell com> wrote:
> > Looks good, please commit.
> >
> > -dave
> >
> >
> >
> > On Wed, 2004-10-06 at 10:38 +0100, Iain * wrote:
> > > With the recent comments on the text beside icons style I took a look
> > > at making it a bit neater. Attached is a patch that lines the icons
> > > and text along a centre line down the middle of the tallest icon.
> > >
> > > An also semi-related change is this
> > > -                       position->x_offset = (MAXIMUM_IMAGE_SIZE -
> > > (icon_bounds.x1 - icon_bounds.x0));
> > > +                       position->x_offset = (icon_width - (bounds.x1
> > > - bounds.x0)) / 2 + ICON_PAD_LEFT;
> > >
> > > It is possible to have an icon that is larger than MAXIMUM_IMAGE_SIZE
> > > if you are viewing the desktop folder as a normal folder and have
> > > stretched an icon. This change lines it up correctly. The
> > > ICON_PAD_LEFT is added because there was no padding for icons in this
> > > style.
> > >
> > > Enjoy, iain
> >
> > --
> > nautilus-list mailing list
> > nautilus-list gnome org
> > http://mail.gnome.org/mailman/listinfo/nautilus-list
> >
> 
> 
>