Re: [PATCH] Bug 142227: alt-up should select folder in parent window



On Fri, 2004-10-15 at 16:01 -0700, Jimmy Do wrote:
> Here's a more thorough patch that fixes this bug:
> http://bugzilla.gnome.org/show_bug.cgi?id=142227

> fm-directory-view.c (selection_changed_callback)
> 	- reveal a new selection if it's set while the view is not loading

The patch in general looks good. I'm not sure I like this part though.
Is scrolling to the first selected item the best thing to do every time
the selection is changed from the shell? I don't think so. Better to
just do it in the cases where we know we want to.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a genetically engineered moralistic card sharp with acid for blood. She's 
a manipulative French-Canadian mercenary with the power to bend men's minds. 
They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]