Re: [PATCH] add location button context menu

[Jürg Billeter <j bitron ch>]

On Fre, 2005-04-29 at 22:06 +0200, Christian Neumair wrote:
> This is the second version of a patch I've submitted about 2.5 months
> ago to nautilus-list [1]. There were no direct followups, but I was now
> asked to update the patch, though, so it looks like people are
> interested in it.
> The new version only has the Cut, Copy, Paste, Trash + Delete and
> Properties items in the context menu, but - in contrast to the last
> version - doesn't make nautilus spit out g_warnings. Also, I've added a
> context menu to the navigation view "Location:" label.
> Comments, suggestions?

First I'd like to thank you for that cool enhancement. Especially the
"Properties" menu item may become very handy for my purposes. Some
comments / bugs:

- Whenever I choose "Copy" in your new menu and then double click on a
subfolder, nautilus crashes (can provide stack trace if you can't
reproduce it)

- Sensitivity of the "Cut", "Move to Trash", and "Delete" actions seems
to be wrong. "Cut" is always sensitive but should probably only be
sensitive when "Move to Trash" and "Delete" are. "Move to Trash" is
sensitive when the _current_ folder is not read only but it should look
at the _parent_ folder. "Delete" is currently sensitive when the current
folder _is_ read only ;) but should of course behave the same way as
"Move to Trash".

- Browser mode: Are you sure that the URI check in
label_button_pressed_callback is right? At first sight it seems like
your comparing the location label, not the URI entry (i.e. you seem to
compare "Location:" with "Location:").

- The action explanations in the status bar (while hovering menu items)
gets overlapped by the menu relatively often but that's a minor issue
and probably not easy avoidable.

HTH,

Jürg

-- 
Jürg Billeter <j bitron ch>