Re: [PATCH] Icon layout incorrect



On Thu, 2005-02-03 at 09:12 +1100, Ian Wienand wrote:
> Hi,
> 
> In bug #161512 Sebastien Bacher requested
> > could you send this patch the nautilus-list for review ? The nautilus
> > maintainers use mainly the list to review patches.
> 
> When getting _NET_WORKAREA information, a length value of G_LONGMAX is
> passed to gdk_property_get().  Internally, gdk_property_get()
> increments this value, causing it to wrap around to zero.  Thus the
> property call doesn't fail, but doesn't return any useful information.
> 
> This manifests in the icon layout being slightly askew, as noted by
> David Mosberger @
> http://lists.debian.org/debian-ia64/2004/12/msg00034.html
> 
> A suggested patch is attached,

Nice catch! I added an extra check for nworkareas == NULL that was
needed, and commited this to cvs.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a lounge-singing small-town vagrant who hides his scarred face behind a 
mask. She's a sharp-shooting mute college professor living homeless in New 
York's sewers. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]