Re: [PATCH] Add Pathbar to Nautilus Browser

[Alexander Larsson <alexl redhat com>]

On Thu, 2005-07-07 at 20:03 +0100, Jamie McCracken wrote:
> Alexander Larsson wrote:
> 
> > First a bit on the general UI. I don't want to have the pathbar in
> > addition to the location bar, I want it to replace the location bar. For
> > a long time a major goal of nautilus has been to avoid displaying
> > pathnames (as in absolute pathnames or uris) in the UI. Going from
> > location bar will help with this. It will also help us look less like a
> > web browser, which is nice, as that can confuse people at times.
> > 
> > Of course, we can't totally remove the location bar, as its needed for
> > typing in addresses, and some people still might want it. What we'll do
> > is put the path bar and the location bar in the same place, but only
> > show one at a time. Normally we show the pathbar, but on "go ->
> > Location" in the menu (or ctrl+l) we temporarily show the location bar,
> > similarly to how this is handled when the location bar is not visible.
> 
> 
> okay done.

This wasn't really what I meant. I changed it to how i think it should
be and commited.
 
> > It doesn't handle the desktop-is-home preference
> 
> done (might need to open new window to get full effect)

I also added code to handle runtime changes of this.
 
> > We should really re-root for all volumes too, not only the homedir. This
> > means you won't see /mnt/media/cdrom, but only
> >   [{cdicon} cdrom name][folder1][folder2]
> > Maybe we can wait a bit with implementing this so that we can get
> > something in first, but this would be really nice.
> >
> 
> done. Also no arrows to the left as its display name is the volume name.

I actually changed this to have the pointer. I agree that its a bit
weird with the naming, but its useful to be able to get to the parent
sometimes. I mean, the home button has a different name than the
filename too.

> > The gtk+ pathbar code you used isn't the latest version. Gtk+ HEAD has a
> > different behaviour, primary wrt rerooting. It:
> > * only re-roots to the desktop
> > * allows you to scroll left when things are re-rooted
> > We should update the code to this version.
> 
> Done. Found a bug in size_allocate which prevented it from applying the 
> scroll arrows when you resize properly. (added on line 425 of 
> nautilus_pathbar.c).

Did you file this bug in bugzilla, so the gtk+ version can be fixed?

Other fixes I did:

* added gconf schema entry for the prefs
* added file to POTFILES.in
* added header file #ifdef protection
* fixed leaks in:
path_bar->desktop_path = gnome_vfs_get_uri_from_local_path (nautilus_get_desktop_directory ());
* finalize can be called multiple, you must NULL out the freed pointer
* is_file_path_mounted_volume leaked the rest of the volumes in the list
if there was a match

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an obese guerilla rock star looking for 'the Big One.' She's a beautiful 
tempestuous schoolgirl with the power to bend men's minds. They fight crime!