Re: [PATCH] - Information-Sidebar should display informations about the selected object (bug 122045)



Am Freitag, den 15.07.2005, 12:34 -0400 schrieb Vincent Noel:
> Previous patch was leaking the selection. Updated patch attached.

...and this one possibly leaks multiple selection_uri strings if
g_list_length (selection) > 1, since the selection loop lacks a break
statement in the if branch. Note that only displaying information for
one selected item is pretty unfriendly.
On the other hand, we should decide what useful things can be done with
the sidebar before implementing random stuff. Just dup'ing the statusbar
selection info also doesn't really help help. To be honest, I don't have
any ideas what the use of this sidebar panel could be for selections.
The information panel in general doesn't convey more information than
the rest of the UI does IMHO.

> 2005/7/15, Vincent Noel <vincent noel gmail com>:
> > Hey all,
> > here is a patch to fix bug 122045 -
> > Information-Sidebar should display informations about the selected object
> > http://bugzilla.gnome.org/show_bug.cgi?id=122045
> > 
> > With this patch, the information sidebar shows information about the
> > current selected object (or the current opened folder if nothing is
> > selected). If several objects are selected, the last selected object
> > is displayed (this is non-optimal but can be improved later...)
> > 
> > I had to make one function public in nautilus-information-panel.
> > 
> > Please comment
> > 
> > Cheers
> > Vincent
> > 
> > 
> >
> -- 
> nautilus-list mailing list
> nautilus-list gnome org
> http://mail.gnome.org/mailman/listinfo/nautilus-list
-- 
Christian Neumair <chris gnome-de org>

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]