Re: [PATCH] Only show "Close Parent Windows" if we're not displaying a toplevel URI

[Alexander Larsson <alexl redhat com>]

On Mon, 2005-05-16 at 18:17 +0200, Christian Neumair wrote:
> Am Montag, den 16.05.2005, 17:26 +0200 schrieb Alexander Larsson:
> > On Thu, 2005-05-12 at 14:02 +0200, Christian Neumair wrote:
> > > >From http://bugzilla.gnome.org/show_bug.cgi?id=149287:
> > > 
> > > 
> > > Proposed patch (against HEAD).
> > > 
> > > - adds nautilus_file_has_parent
> > > - adds nautilus_window_(info_)update_menus, which is called when updating the
> > > menus and implemented by all subclasses of NautilusWindow
> > 
> > the NautilusWindow menu only needs updating when the location changes.
> 
> Ouch, I've overlooked that. Thanks for pointing it out.
> 
> > The right thing to make the spatial window always update the sensitivity
> > when you change the location. Fortunately we already track all this for
> > the "up" button in navigational mode. So you just need to hook off
> > nautilus_window_allow_up().
> 
> Nice. Proposed patch #2 attached. Do you like the way the methods are
> invoked?

That looks ok, but you don't need nautilus_file_has_parent, just use the
"allowed" boolean that gets passed to set_allow_up.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an all-American guerilla werewolf on his last day in the job. She's a 
scantily clad Bolivian safe cracker with someone else's memories. They fight 
crime!