Re: [PATCH] Fix notebook keynav in property window

[Alexander Larsson <alexl redhat com>]

On Sun, 2005-10-09 at 22:48 +0200, Christian Neumair wrote:
> The keybindings for switching tabs in notebooks doesn't always work for
> the file properties window's notebook, filed as bug 318354 [1].
> 
> The attached patch fixes that.
> 
> Note that a new diff is required as soon as the "Custom Image" button
> changes are in for HEAD.
> 
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=318354

I don't like this patch. It just overrides all keynav on widgets in the
property dialog to the notebook, totally overriding the normal Gtk+
keybinding order. This means it breaks keynav in e.g. the notebook
entry.

Of course, some of the widget in the property page unnecessary consumes
ctrl-pgup/down, like the emblems list and the open with list, and we
should make them not do that. However, ctrl-pgup/downit is useful in the
notes page and possibly in custom pages. In these pages you really have
to put focus on the tab to make the tab keynav work, just like all other
gtk+ apps.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a globe-trotting ninja gentleman spy on a mission from God. She's a 
tortured bisexual museum curator from beyond the grave. They fight crime!