Re: [PATCH] Virtual folder properties

["Gene Z. Ragan" <diskzero mac com>]

> The various virtual folders that tend to inhabit the average  
> Nautilus desktop have a number of items on their properties windows  
> that don't really make sense (Permissions for example). There has  
> been some work towards removing some of these for the Trash folder,  
> but not so much for the Computer and Network Folders. This patch  
> goes a bit further, partly by introducing a "all_virtual_folders"  
> function to check if all of the currently selected items are in  
> fact virtual folders, and using that function liberally as a check  
> as to whether various things should turn up on the Properties window.
>
> Tom Parker
> <virtual-folders.patch>
> --
> nautilus-list mailing list
> nautilus-list gnome org
> http://mail.gnome.org/mailman/listinfo/nautilus-list


Tom,

I try to use the same informative naming conventions for internal  
static functions that are used for the public ones.  In the case of  
your new all_virtual_folders function, I would try to name it  
something that is a little more clear when the name in appended to  
the argument.  In this case, window_all_virtual_folders is a little  
vague. Something like contains_only_virtual_folders would work well  
and be descriptive.

I am also wondering why NautilusFile does not have a method that does  
this.  You can query the file if it is a symlink, on the desktop, in  
the trash, etc.  It would seem that the "virtual" property could be  
queried as well.   All of the logic could be contained there and you  
wouldn't have to come back to fm-properties-window in the future and  
add more types to compare against.  I bet Alex or someone more  
knowledgeable about this will know the answer.

Thanks!

Gene