[PATCH] Use thumbnail limits for videos



The routine mimetype_limited_by_size in libnautilus-private should say whether a particular mime type should be effected by the size limits for thumbnailing or not. With my reading of the text in the Preview tab of the file management properties, it looks like everything *other* than text or audio files should be limited if the option is picked. However, the code indicates that only images are limited. Video files can be thumbnailed, and are much more likely to exceed the size limits, but aren't included in the "image_mime_types" list. Therefore, the attached patch drops the list entirely, and rewrites mimetype_limited_by_size so it checks if the mimetype is text or audio (returning FALSE) or something else (returning TRUE), thus also allowing for other future types that come under the "Other" mentioned by the file management properties. This corrects the discrepancy between the code and the text, and makes video thumbnails have the same limits as image thumbnails.

Also, someone with HIG skills should probably look at the Preview tab of the file management properties. At the least, the "Other" section should probably be moved down to make it less ambiguous. Usually, an "Other" category comes after all the "not-other" categories, not in the middle between two non-other categories (Text and Audio).

Tom Parker

Attachment: fix-limited-types.patch
Description: Binary data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]