Re: [PATCH] Improve session management, attempt 2

[Alexander Larsson <alexl redhat com>]

On Fri, 2006-06-16 at 16:01 +0200, Christian Neumair wrote:
> The attached patch is a new attempt to implement session management,
> this time the calls are proxied through NautilusShell (thus operating on
> the server), session names are generated on the fly and a
> "--load-session" parameter was added. Also, the session file is not
> removed when it is not readable or no regular file, so that one can
> manually load a particular session on startup.

I had a quick check over it and it generally looks good.

Some things i noticed:
@@ -109,7 +109,7 @@ AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE,"$GET
 AM_GLIB_GNU_GETTEXT
 GLIB_DEFINE_LOCALEDIR(GNOMELOCALEDIR)
 
-IT_PROG_INTLTOOL([0.34.90])
+IT_PROG_INTLTOOL([0.34.2])
 
 dnl ==========================================================================
 

We need the newer version for the new gettext stuff.


@@ -617,6 +623,10 @@ nautilus_application_startup (NautilusAp
 		} else if (!no_default_window) {
 			Nautilus_Shell_open_default_window (shell, corba_startup_id, corba_geometry, browser_window, &ev);
 		}
+
+		if (session_to_load != NULL) {
+			Nautilus_Shell_load_session (shell, session_to_load, &ev);
+		}
 		
 		/* Add ourselves to the session */
 		init_session ();


We shouldn't open a default window in this case. Did you handle that?


+	g_message ("is %s\n", filename);

Debug spew


@@ -13,6 +13,7 @@ module Nautilus {
 	interface Shell : ::Bonobo::Unknown {
 		void open_windows (in URIList uris, in string startup_id, in string geometry, in boolean browser_window);
 		void open_default_window (in string startup_id, in string geometry, in boolean browser_window);
+		void load_session (in string filename);

Add new methods to the end of the interface, that minimizes bizzare
backwards compat issues.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a scarfaced zombie boxer with a winning smile and a way with the ladies. 
She's a disco-crazy French-Canadian opera singer trying to make a difference 
in a man's world. They fight crime!