Re: patch nag: handle CORBA errors

[Frederic Crozat <fcrozat mandriva com>]

Le mercredi 13 septembre 2006 à 10:21 +0200, Alexander Larsson a écrit :
> On Tue, 2006-09-12 at 21:23 +0200, Christian Neumair wrote:
> > See bug http://bugzilla.gnome.org/show_bug.cgi?id=46664 . We sometimes
> > even access the result data without checking for CORBA errors, which is
> > a no-no and may well be the cause of bug
> > http://bugzilla.gnome.org/show_bug.cgi?id=353629 .
> 
> Yes, that looks good. Please commit.
> 
> I don't think it will fix the bug though, all metadata accesses through
> corba are in-process these days, so we generally shouldn't be getting
> any corba failures.

I've tried to apply this patch on nautilus 2.16.0 and got the following
assert :

Memory status: size: 83120128 vsize: 0 resident: 83120128 share: 0 rss:
15269888 rss_rlim: 0
CPU usage: start_time: 1158161324 rtime: 0 utime: 149 stime: 0
cutime:136 cstime: 0 timeout: 13 it_real_value: 0 frequency: 0

Backtrace was generated from '/usr/bin/nautilus'

Using host libthread_db library "/lib/i686/libthread_db.so.1".
`shared object read from target memory' has disappeared; keeping its
symbols.
[Thread debugging using libthread_db enabled]
[New Thread -1227859648 (LWP 1591)]
0xbfffe410 in __kernel_vsyscall ()
#0  0xbfffe410 in __kernel_vsyscall ()
#1  0xb709b2cb in __waitpid_nocancel () from /lib/i686/libpthread.so.0
#2  0xb7d814e7 in libgnomeui_segv_handle (signum=6) at
gnome-ui-init.c:870
#3  <signal handler called>
#4  0xbfffe410 in __kernel_vsyscall ()
#5  0xb6d63fc0 in raise () from /lib/i686/libc.so.6
#6  0xb6d65851 in abort () from /lib/i686/libc.so.6
#7  0xb7027d4f in IA__g_logv (log_domain=) at gmessages.c:497
#8  0xb7027d8b in IA__g_log (log_domain=0x0,
log_level=G_LOG_LEVEL_ERROR, 
    format=0xb7052620 "file %s: line %d (%s): assertion failed: (%s)")
    at gmessages.c:517
#9  0xb7027e0c in IA__g_assert_warning (log_domain=0x0, 
    file=0x815bffa "nautilus-metafile.c", line=798, 
    pretty_function=0x815c501 "corba_register_monitor", 
    expression=0x815c0e8 "found || error != NULL") at gmessages.c:552
#10 0x0811d56f in corba_register_monitor (servant=0x8296244,
monitor=0x31e, 
    ev=0xbff29c28) at nautilus-metafile.c:798
#11 0xb71180e8 in ORBit_c_stub_invoke (obj=0x82a6d18,
methods=0x81817e4, 
    method_index=9, ret=0x0, args=0xbff29bf8, ctx=0x0, ev=0xbff29c28, 
    class_id=10, method_offset=40, 
    skel_impl=0x8069510
<_ORBIT_skel_small_Nautilus_Metafile_register_monitor>)
    at poa.c:2630
#12 0x08067ea0 in Nautilus_Metafile_register_monitor (_obj=0x82a6d18, 
    monitor=0x82a6f78, ev=0xbff29c28) at
nautilus-shell-interface-stubs.c:104
#13 0x080e7ebb in nautilus_directory_register_metadata_monitor (
    directory=0x81e5810) at nautilus-directory-metafile.c:621
#14 0x080e64b4 in nautilus_directory_call_when_ready_internal (
    directory=0x81e5810, file=0x81e7998, file_attributes=896, 
    wait_for_file_list=0, directory_callback=0, 
    file_callback=0x8131c80 <ready_callback>, callback_data=0x82a6560)
    at nautilus-directory-async.c:1309
#15 0x08131ea5 in desktop_directory_file_call_when_ready
(file=0x81e7998, 
    attributes=896, 
    callback=0x80978a0 <got_file_info_for_view_selection_callback>, 
    callback_data=0x8214808) at nautilus-desktop-directory-file.c:294
#16 0x080fae15 in nautilus_file_call_when_ready (file=0x81e7998, 
    file_attributes=896, 
    callback=0x80978a0 <got_file_info_for_view_selection_callback>, 
    callback_data=0x8214808) at nautilus-file.c:5548
#17 0x08096ca2 in begin_location_change (window=0x8214808, 
    location=0x81402f9 "x-nautilus-desktop:", new_selection=0x0, 
    type=NAUTILUS_LOCATION_CHANGE_STANDARD, distance=0, scroll_pos=0x0)
    at nautilus-window-manage-views.c:773
#18 0x08099901 in nautilus_window_open_location (window=0x8214808, 
    location=0x81402f9 "x-nautilus-desktop:", close_behind=0)
    at nautilus-window-manage-views.c:580
#19 0x0809cd51 in nautilus_window_go_to (window=0x8214808, 
    uri=0x81402f9 "x-nautilus-desktop:") at nautilus-window.c:243
#20 0x08072539 in nautilus_desktop_window_update_directory
(window=0x8214808)
    at nautilus-desktop-window.c:88
#21 0x0807265a in nautilus_desktop_window_new (application=0x818e1b0, 
    screen=0x81b00f8) at nautilus-desktop-window.c:132
#22 0x0806b22b in nautilus_application_open_desktop
(application=0x818e1b0)
    at nautilus-application.c:904
#23 0xb71180e8 in ORBit_c_stub_invoke (obj=0x81f4888,
methods=0x8181a64, 
    method_index=2, ret=0x0, args=0x0, ctx=0x0, ev=0xbff29f24,
class_id=8, 
    method_offset=12, 
    skel_impl=0x80695f0
<_ORBIT_skel_small_Nautilus_Shell_start_desktop>)
    at poa.c:2630
#24 0x08067c46 in Nautilus_Shell_start_desktop (_obj=0x81f4888,
ev=0xbff29f24)
    at nautilus-shell-interface-stubs.c:144
#25 0x0806bfd9 in nautilus_application_startup (application=0x818e1b0, 
    kill_shell=0, restart_shell=0, no_default_window=1, no_desktop=0, 
    do_first_time_druid_check=1, browser_window=0, 
    startup_id=0x81bf508 "_TIME2815123734", geometry=0x0,
session_to_load=0x0, 
    urls=0x0) at nautilus-application.c:638
#26 0x0807c885 in main (argc=) at nautilus-main.c:359
#27 0xb6d5175c in __libc_start_main (main=0x807bfe0 <main>, argc=8, 
    ubp_av=0xbff2a234, init=0x813e0a0 <__libc_csu_init>, 
    fini=0x813e090 <__libc_csu_fini>, rtld_fini=0xb7fa03b0 <_dl_fini>, 
    stack_end=0xbff2a22c) at libc-start.c:231
#28 0x080679d1 in _start ()

-- 
Frederic Crozat <fcrozat mandriva com>
Mandriva