Re: [PATCH] Use thumbnail limits for videos



On Wed, 2006-12-27 at 23:56 +0100, Tom Parker wrote:
> The routine mimetype_limited_by_size in libnautilus-private should say
> whether a particular mime type should be effected by the size limits
> for thumbnailing or not. With my reading of the text in the Preview
> tab of the file management properties, it looks like everything
> *other* than text or audio files should be limited if the option is
> picked. However, the code indicates that only images are limited.
> Video files can be thumbnailed, and are much more likely to exceed the
> size limits, but aren't included in the "image_mime_types" list.

This is quite reasonable. Thumbnailing a large image will take a long
time. However, thumbnailing a very very very large movie will not
generally take longer than a small one (we just grab an early frame).
So, by using the size limits for movies we essentially break the movie
thumbnailing feature.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a Nobel prize-winning alcoholic inventor on the hunt for the last 
specimen of a great and near-mythical creature. She's an enchanted blonde 
archaeologist on the trail of a serial killer. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]