Re: [PATCH] Fix autorun + mounts outside /media

[Sebastien Bacher <seb128 ubuntu com>]

Hey David,

Le mercredi 16 avril 2008 à 02:05 -0400, David Zeuthen a écrit :

> There's currently a really bad bug in Nautilus where we insist on
> autorunning a mount even if Nautilus didn't automount itself. For
> example if I mount something from the command line or another app, then
> Nautilus will open a window with the default settings. This also happens
> from live cd installers. The attached patch fixes that problem and
> somewhat simplifies the code. Instead of trying to inhibit autorunning
> from all call sites, we simply only allow autorunning from the function
> where we do automounting.

Thanks for the work on that, the current behaviour is an annoyance for
quite some users. That fixes also rhythmbox being started after the
login when you have an audio cd in the drive.
One side effect is that selecting a non mounted volume in the panel
places menu just create an icon on the desktop and doesn't run nautilus
to browse the new location but that's rather a gnome-panel issue.

> The other patch is for gvfs and is also related to live cd installers.
> Our policy, more or less, is that we only want to show mounts
> in /media/* and inside $HOME. Currently this is limited to /etc/fstab
> only. However, live cd installers typically like to mount partitions to
> actually install files on them. So when they do that, we show an icon on
> the desktop... which is not exactly ideal. The attached patch ensures we
> hide GVolume and GMount objects for mounted file systems outside /media
> and $HOME. 

Right, I think that makes sense too.

I've tried the changes and uploaded to ubuntu hardy since they seem to
work correctly, I'll post feedback if any new issue is raised but I
think that commiting to trunk and gnome-2-22 should be alright


Cheers,

Sebastien Bacher