Re: gio, gvfs and nautilus fixes

[Claude Paroz <claude 2xlibre net>]

Le samedi 23 février 2008 à 14:16 -0500, David Zeuthen a écrit :
> Hi Claude,
> 
> (please keep nautilus-list gnome org and alexl in the Cc)
> 
> On Sat, 2008-02-23 at 10:34 +0100, Claude Paroz wrote:
> > Le vendredi 22 février 2008 à 15:43 -0500, David Zeuthen a écrit :
> > > Hey Alex,
> > > 
> > > (Hi i18n team: there's a string break request near the end of this
> > > mail)
> > > 
> > (snip)
> > > 
> > > i18n team: This is in the patch that adds new strings
> > > 
> > > http://people.freedesktop.org/~david/gvfs-fixes-2.patch
> > > 
> > > Most of the strings are in the gphoto2 backend. Almost all of them
> > > (except one or two) are not user-visible under normal circumstances as
> > > they are mostly error messages. Requesting permission to commit this.
> > > Thanks.
> > 
> > Hi David,
> > 
> > Please don't ask translators to 'decypher' patches :-P
> > You won't obtain the green light if you don't motivate this a little
> > more. Concerning not user-visible strings, don't mark them for
> > translation now, and keep a bug open to not forget to mark them after
> > module branching.
> 
> 
> OK, the non-essential error messages have been unmarked for translation
> but are easy to add back. I've filed a bug for this
> 
>  http://bugzilla.gnome.org/show_bug.cgi?id=518284
> 
> and referenced the bug in the source code too.

Nice, thanks.

> > If there are user-visible strings, tell us which strings are concerned
> > and why this is critical for GNOME 2.22.
> 
> With the new patch 
> 
>  http://people.freedesktop.org/~david/gvfs-fixes-3.patch
> 
> here's what changed
> 
> Strings changed:
> 
>  C1 "Audio Disc on %s" changed to "cdda mount on %s"
> 
> Strings added:
> 
>  A1: "%s Audio Player"
>  A2: "Audio Player"
>  A3: "gphoto2 mount on %s"
>  A4: "Digital Camera (%s)"
> 
> Analysis: Of these the strings C1 and A3 are only visible for
> commandline users as they are used only in ~/.gvfs (it's an open
> question if we should even translate such strings). The remaining
> strings are only visible when connecting cameras and audioplayers using
> PTP/MTP. As most of such devices use mass storage these days, few users
> will see them anyway. 
> 
> So hoping this analysis explains that the i18n impact of this change is
> pretty low. Requesting permission to land these string changes. Thanks!

Thanks David for that well-presented explanation. Even if C1 and A3
could have been treated the same way as the non user-visible strings, I
think it makes a whole with A1/A2/A4.
I just ask you to add translator comments for strings containing
placeholders, especially when this can affect the meaning (A1 seems the
most obvious).
Approval 1 of 2.

Claude