Re: [PATCH] nautilus_file_get_gicon() shouldn't dereference NULL file

[Christian Neumair <cneumair gnome org>]

Am Mittwoch, den 27.02.2008, 15:31 +0100 schrieb Alexander Larsson:
> Did you actually verify this crash?
> I'm not sure how file got NULL as it comes from a
> nautilus_file_get(location) call. But i guess location could be NULL. 
> 
> Anyway, it should be safe to commit. But are we sure it fixes the bug?

You are right, I could not verify/reproduce this crash. I verified and
agree that this should only happen in the location == NULL case.

In general, we're not very robust wrt broken user data ATM, missing
glade files or " " (two spaces) lines in bookmark files cause asserts to
fail. Also note that in Thread 1#1 of the BT, there is a line containing

"** Message: failed to load session
from /home/ron/.nautilus/saved-session-X"

so the user's data might be somewhat broken.

best regards,
 Christian Neumair

-- 
Christian Neumair <cneumair gnome org>