Re: [PATCH] Show potential apps first on 'Open with...' dialog

[Rodrigo Moya <rodrigo gnome-db org>]

On Fri, 2008-02-22 at 09:34 +0100, Alexander Larsson wrote:
> On Thu, 2008-02-21 at 15:42 +0100, Rodrigo Moya wrote:
> > On Thu, 2008-02-21 at 14:44 +0100, Alexander Larsson wrote:
> > > On Wed, 2008-02-20 at 18:58 +0100, Rodrigo Moya wrote:
> > > > Hi
> > > > 
> > > > The openSUSE eel package had a patch that stopped applying with latest
> > > > update to 2.21.x, to make eel-open-with-dialog show first the apps
> > > > associated to the given mime type.
> > > > 
> > > > I've tried adapting the patch to Nautilus, but can't find why, it seems,
> > > > g_app_info_get_all_for_type always returns NULL.
> > > > 
> > > > Find attached the patch and please let me know if this would acceptable
> > > > (for 2.23.x of course, in which case I'll file a bug with the patch)
> > > 
> > > I don't get it. Aren't all those applications already listed in the open
> > > with menu? They should be...
> > > 
> > they are, but if you open the dialog, this patch makes it show those
> > apps first on the open with dialog, then the rest, in a 'All
> > applications' node in the tree. It just makes it easier for users that
> > get to the dialog. If no app is defined for the mime type, it just works
> > as it does now in SVN, that is, it shows all apps on a flat list.
> 
> Ok, so it (more or less) duplicates the menu since you may have missed
> something in the menu when you selected "open with..." in the menu. It
> seems to me that for the common case (where you actually wanted to open
> with an app not already in the open with menu) this patch just forces
> you to do an additional click, in favour of helping the few people who
> accidentally miss the app they were looking for in the menu.
> 
ok, if there's no case where the user opens this dialog without having
first seen a list of possible apps, then I guess we can drop the patch
-- 
Rodrigo Moya <rodrigo gnome-db org>
>