Re: [PATCH] Don't show frames around images with an alpha plane

[Mark <markg85 gmail com>]

For your patch. You claim it fixes #585186 but i have a hard time
believing that. That bug report is talking about small images getting
upscaled. And in your patch:
(one liner)
if (!gdk_pixbuf_get_has_alpha(raw_pixbuf)) {

that doesn't fix the small images getting upscaled. That's only not
framing images with alpha and i disagree on having no frame on them.
I could be wrong and completely missing the nail here but just looking
at the gdk_pixbuf_get_has_alpha description that function alone should
not be able to fix #585186

btw. i'm not a nautilus maintainer (just a user).

On Sun, Sep 6, 2009 at 9:46 PM, Jaap A. Haitsma <jaap haitsma org> wrote:
> Very small patch that doesn't show a frame around images with an alpha
> plane which makes the images look a lot better
>
> It's actually a modification of this patch which I committed a wile ago
>
> commit 2a94803b44010e3c47a9f7b94894fab8d6062abc
> Author: Jaap A. Haitsma <jaap haitsma org>
> Date:   Sat Jul 18 20:45:05 2009 +0200
>
>    Fix handling of small images/icons
>
>    Small images with an alpha plane don't get a frame
>    Use different scaling strategy for small images. Small images/icons
>    won't get up scaled in default zoom view. They are shown in their actual
>    Fixes bug #585186
>
>
> Can I commit the attached patch?
>
> Jaap
>
> --
> nautilus-list mailing list
> nautilus-list gnome org
> http://mail.gnome.org/mailman/listinfo/nautilus-list
>